Skip to content

/ LocalizedStringKit

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tableName support for string segmentation #11

Merged
merged 5 commits into from Sep 10, 2020
Merged

Add tableName support for string segmentation #11

merged 5 commits into from Sep 10, 2020

Conversation

@AfrazCodes
Copy link
Contributor

@AfrazCodes AfrazCodes commented Sep 9, 2020 •
edited

Changes

  • Add support for multiple tableNames
  • Update static cacheing to use dictionary for bundles rather than single bundle
  • Update tests with new API signature
  • Improve nullability annotations
Afraz Siddiqui
Add tableName support for string segmentation
Loading status checks…
fbd8400
@nickromano
nickromano reviewed Sep 9, 2020
View changes
Sources/LocalizedStringKit/include/LocalizedStringKit.h Outdated Show resolved Hide resolved
@a2
a2 reviewed Sep 9, 2020
View changes
LocalizedStringKit.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Sources/LocalizedStringKit/include/LocalizedStringKit.h Outdated Show resolved Hide resolved
Sources/LocalizedStringKit/LocalizedStringKit.m Show resolved Hide resolved
Sources/LocalizedStringKit/LocalizedStringKit.m Outdated Show resolved Hide resolved
AfrazCodes and others added 3 commits Sep 9, 2020
@AfrazCodes @a2
Update Sources/LocalizedStringKit/LocalizedStringKit.m
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b58d456 
Co-authored-by: Alexsander Akers <me@a2.io>
@AfrazCodes @a2
Update LocalizedStringKit.xcodeproj/project.pbxproj
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ad23a5d 
Co-authored-by: Alexsander Akers <me@a2.io>
Afraz Siddiqui
PR feedback
Loading status checks…
edcece4
@a2
a2 reviewed Sep 9, 2020
View changes
Sources/LocalizedStringKit/LocalizedStringKit.m Show resolved Hide resolved
@a2
a2 approved these changes Sep 9, 2020
View changes
@nickromano
nickromano approved these changes Sep 9, 2020
View changes
@dalemyers
dalemyers approved these changes Sep 10, 2020
View changes
Sources/LocalizedStringKit/LocalizedStringKit.m Outdated Show resolved Hide resolved
Afraz Siddiqui
Formatting
Loading status checks…
4ad9f2f
@AfrazCodes AfrazCodes merged commit 9b1cfb5 into microsoft:master Sep 10, 2020
4 checks passed
4 checks passed
license/cla All CLA requirements met.
Details
microsoft.LocalizedStringKit Build #20200910.1 succeeded
Details
microsoft.LocalizedStringKit (Build and Test Generation Tool Python37) Build and Test Generation Tool Python37 succeeded
Details
microsoft.LocalizedStringKit (Build and Test iOS Library) Build and Test iOS Library succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickromano nickromano

@a2 a2

@dalemyers dalemyers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@AfrazCodes @nickromano @a2 @dalemyers
You can’t perform that action at this time.