Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Custom Tabs link #404

Open
wants to merge 2 commits into
base: master
from
Open

Update Custom Tabs link #404

wants to merge 2 commits into from

Conversation

@slang25
Copy link

@slang25 slang25 commented Sep 4, 2018

No description provided.

@codecov-io
Copy link

@codecov-io codecov-io commented Sep 4, 2018

Codecov Report

Merging #404 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #404   +/-   ##
=========================================
  Coverage     83.69%   83.69%           
  Complexity      478      478           
=========================================
  Files            42       42           
  Lines          2343     2343           
  Branches        233      233           
=========================================
  Hits           1961     1961           
  Misses          299      299           
  Partials         83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 390a6c9...83ce822. Read the comment docs.

@iainmcgin
Copy link
Member

@iainmcgin iainmcgin commented Sep 5, 2018

Thanks for this! Could you sign the OpenID Foundation CLA, and then I can merge this? You can add yourself to the CONTRIBUTORS file as part of this PR too.

@slang25
Copy link
Author

@slang25 slang25 commented Sep 7, 2018

Thanks @iainmcgin, I've filled out the CLA as requested 😃

@iainmcgin
Copy link
Member

@iainmcgin iainmcgin commented Sep 11, 2018

Sorry @slang25, I don't see you on the list maintained by the OIDF - are you covered by one of the corporate agreements? If not, it may just be that the lawyers at the OIDF haven't updated the list yet, I'll check with them too.

@iainmcgin
Copy link
Member

@iainmcgin iainmcgin commented Sep 20, 2018

@slang25 I just reached out to the OIDF CLA admins, they say that they have not yet received a copy of the CLA from you. Could you please fill out either the individual or corporate CLA from this page and email it to help@oidf.org?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.