Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Allow jekyll-loading-lazy plugin #691
Open
+16
−1
Conversation
Making the generated sites load faster by utilizing native lazy loading with [jekyll-loading-lazy](https://github.com/gildesmarais/jekyll-loading-lazy). The change regarding the expected image url in jekyll-avatar spec stems from Nokogiri's handling of urls (which is basically done on libxml2's end). See sparklemotion/nokogiri#1127 (comment) for more details on that topic. The encoding of the ampersand in the search params of the image url does not cause the url to break or point to an invalid location. I'd love to see my Jekyll plugin become allowed and ready to use on Github Pages. Thank you!
|
+1 This would be a great and safe addition. |
gildesmarais
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Making the generated sites load faster by utilizing native lazy loading
with jekyll-loading-lazy.
The change regarding the expected image url in jekyll-avatar spec
stems from Nokogiri's handling of urls (which is basically done on
libxml2's end). See
sparklemotion/nokogiri#1127 (comment)
for more details on that topic. The encoding of the ampersand in the
search params of the image url does not cause the url to break or point
to an invalid location.
I'd love to see my Jekyll plugin become allowed and ready to
use on Github Pages. Thank you!