Skip to content

/ react-testing-library

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Trigger onPointerEnter/Leave when calling pointerEnter/Leave #784

Merged
merged 5 commits into from Sep 13, 2020
Merged

fix: Trigger onPointerEnter/Leave when calling pointerEnter/Leave #784

merged 5 commits into from Sep 13, 2020

Conversation

@karthick3018
Copy link
Contributor

@karthick3018 karthick3018 commented Sep 12, 2020

Pointer events added:

Existing code doesn't include pointer events:

Similar to the mouse events:

Checklist:

  • Documentation added to the N/A
    docs site
  • Tests
  • Typescript definitions updated N/A
  • Ready to be merged
@karthick3018
adding pointer events
Loading status checks…
525ec66
@codesandbox
Copy link

@codesandbox codesandbox bot commented Sep 12, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8b106fa:

Sandbox Source
React Configuration
kentcdodds/react-testing-library-examples Configuration
@kentcdodds
Copy link
Member

@kentcdodds kentcdodds commented Sep 12, 2020

Thanks for this! Could we get some tests please?
@karthick3018
test for pointer event
6729ef3
@karthick3018
removing a typo
Loading status checks…
7f20442
@karthick3018
Copy link
Contributor Author

@karthick3018 karthick3018 commented Sep 13, 2020 •
edited

Thanks for this! Could we get some tests please?

hey @kentcdodds nice to hear from you! added a passing test case
@karthick3018
event name change
Loading status checks…
ba38405
@karthick3018
test for pointer leave
Loading status checks…
8b106fa
@codecov
Copy link

@codecov codecov bot commented Sep 13, 2020 •
edited

Codecov Report

Merging #784 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #784   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          109       117    +8     
  Branches        16        16           
=========================================
+ Hits           109       117    +8
Impacted Files Coverage Δ
src/fire-event.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865c4fd...8b106fa. Read the comment docs.
@kentcdodds
kentcdodds approved these changes Sep 13, 2020
View changes
Copy link
Member

@kentcdodds kentcdodds left a comment

LGTM. What do you think @eps1lon?
@eps1lon eps1lon changed the title This will solve #783 fix: Trigger onPointerEnter/Leave when calling pointerEnter/Leave Sep 13, 2020
@eps1lon eps1lon merged commit c7b5622 into testing-library:master Sep 13, 2020
4 checks passed
4 checks passed
ci/codesandbox Building packages succeeded.
Details
codecov/patch Codecov Report
Details
codecov/project Codecov Report
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 13, 2020

@all-contributors add @karthick3018 for code
@allcontributors allcontributors bot mentioned this pull request Sep 13, 2020
Merged
@allcontributors
Copy link
Contributor

@allcontributors allcontributors bot commented Sep 13, 2020

@eps1lon

I've put up a pull request to add @karthick3018! 🎉
@testing-library-bot
Copy link

@testing-library-bot testing-library-bot commented Sep 13, 2020

🎉 This PR is included in version 11.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀
@eps1lon eps1lon mentioned this pull request Sep 13, 2020
Closed
@karthick3018 karthick3018 deleted the karthick3018:pr/fix783 branch Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@karthick3018 @kentcdodds @eps1lon @testing-library-bot
You can’t perform that action at this time.