Skip to content

/ react-weui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update picker #219

Open
wants to merge 1 commit into
base: master
from
Open

update picker #219

wants to merge 1 commit into from

Conversation

@ruoru
Copy link

@ruoru ruoru commented Mar 22, 2017 •
edited

issue #218
@coveralls
Copy link

@coveralls coveralls commented Mar 22, 2017

Coverage Status

Coverage increased (+6.5%) to 88.564% when pulling b58a43d on ruoru:update/picker into 01bc1c5 on weui:master.
@n7best n7best self-requested a review Mar 22, 2017
@n7best n7best mentioned this pull request Mar 22, 2017
Open
@coveralls
Copy link

@coveralls coveralls commented Mar 31, 2017

Coverage Status

Coverage increased (+6.5%) to 88.574% when pulling 1148af5 on ruoru:update/picker into 01bc1c5 on weui:master.
@ruoru
Copy link
Author

@ruoru ruoru commented Jan 16, 2018 •
edited

Sorry, this branch is too long, I am more lazy :), oh, this repo have not update for six months, I will rebase and to solve #218, maybe some question are solved.
@ruoru ruoru force-pushed the ruoru:update/picker branch from 1148af5 to ce8b28a Jan 16, 2018
@coveralls
Copy link

@coveralls coveralls commented Jan 16, 2018 •
edited

Coverage Status

Coverage decreased (-7.2%) to 74.306% when pulling 06eac4f on ruoru:update/picker into f8b12cd on weui:master.
@ruoru ruoru changed the title 优化picker_group update picker_group Jan 16, 2018
@ruoru ruoru changed the title update picker_group update picker Jan 16, 2018
@ruoru
Copy link
Author

@ruoru ruoru commented Jan 16, 2018 •
edited

when i merge 1.1.3 and install package start, there are some error:

npm WARN deprecated babel@6.23.0: In 6.x, the babel package has been deprecated in favor of babel-cli. Check https://opencollective.com/babel to support the Babel maintainers
npm WARN deprecated jade@0.26.3: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated to-iso-string@0.0.2: to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

npm WARN react-weui@1.1.3 requires a peer of react@0.14.x || ^15.0.0-0 || 15.x but none is installed. You must install peer dependencies yourself.
npm WARN react-weui@1.1.3 requires a peer of react-dom@^0.14.x || ^15.0.0-0 || 15.x but none is installed. You must install peer dependencies yourself.
npm WARN babel-loader@6.4.1 requires a peer of webpack@1 || 2 || ^2.1.0-beta || ^2.2.0-rc but none is installed. You must install peer dependencies yourself.
npm WARN enzyme@2.7.1 requires a peer of react@0.13.x || 0.14.x || ^15.0.0-0 || 15.x but none is installed. You must install peer dependencies yourself.
npm WARN html-webpack-plugin@2.28.0 requires a peer of webpack@1 || ^2 || ^2.1.0-beta || ^2.2.0-rc but none is installed. You must install peer dependencies yourself.
npm WARN react-addons-test-utils@15.4.2 requires a peer of react-dom@^15.4.2 but none is installed. You must install peer dependencies yourself.
npm WARN react-codemirror@0.2.6 requires a peer of react@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-fontawesome@1.5.0 requires a peer of react@>=0.12.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-router@4.2.0 requires a peer of react@>=15 but none is installed. You must install peer dependencies yourself.
npm WARN react-router-dom@4.2.2 requires a peer of react@>=15 but none is installed. You must install peer dependencies yourself.
npm WARN react-transition-group@2.2.1 requires a peer of react@>=15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-transition-group@2.2.1 requires a peer of react-dom@>=15.0.0 but none is installed. You must install peer dependencies yourself.

now i can not run well, maybe fix this problem will run well.

this issue solved in #258
@ruoru ruoru mentioned this pull request Jan 18, 2018
Open
@ruoru ruoru force-pushed the ruoru:update/picker branch 2 times, most recently from f623fc3 to ea8c656 Jan 27, 2018
@ruoru ruoru force-pushed the ruoru:update/picker branch 2 times, most recently from 0d9b205 to 8af2426 Feb 5, 2018
@ruoru
Copy link
Author

@ruoru ruoru commented Feb 5, 2018 •
edited

i am already fix it and please review it, If there is no problem I hope to merge it. @weui
@ruoru ruoru force-pushed the ruoru:update/picker branch 2 times, most recently from 3ae76c0 to 98dbaa3 Feb 5, 2018
ruoru @ruoru
issue #218 update picke and picker_column code
Loading status checks…
06eac4f
@ruoru ruoru force-pushed the ruoru:update/picker branch from 75fd74c to 06eac4f Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n7best n7best

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ruoru @coveralls
You can’t perform that action at this time.