Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Added OpenMode property for DrawerHost #789
Open
+200
−84
Conversation
- so that to be consistent with the DialogHost, which also have this property
- but now it is not possible to close a pinned drawer
- will do animation now
Keboo
force-pushed the
wongjiahau:Add-OpenModeProperty-for-DrawerHost
branch
from
09d89c0
to
f3f2d5d
Keboo
force-pushed the
wongjiahau:Add-OpenModeProperty-for-DrawerHost
branch
from
f3f2d5d
to
7e9fa3c
|
TODO Items before release
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
@ButchersBoy I've already implemented the OpenModeProperty for DrawerHost, but I'm not sure if the API looks like what you want.
Currently, the API looks like this :
Issues : If OpenMode is set to Pinned, all the drawers works as expected, however only the BottomDrawer does not push the main content when it is opened. I'm not sure why though.