Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate material to nullsafety #67166

Open
wants to merge 1 commit into
base: master
from
Open

migrate material to nullsafety #67166

wants to merge 1 commit into from

Conversation

@a14n
Copy link
Contributor

@a14n a14n commented Oct 2, 2020

Description

NNBD migration for material

Related Issues

Tests

I added the following tests:

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@@ -120,58 +120,58 @@ class ButtonStyle with Diagnosticable {
///
/// The color of the [textStyle] is typically not used directly, the
/// [foregroundColor] is used instead.
final MaterialStateProperty<TextStyle>? textStyle;
final MaterialStateProperty<TextStyle?>? textStyle;

This comment has been minimized.

@Hixie

Hixie Oct 2, 2020
Contributor

@HansMuller this double-level of nullness looks suspicious, is it what we want?


@override
Color resolve(Set<MaterialState> states) {
Color? resolve(Set<MaterialState> states) {

This comment has been minimized.

@Hixie

Hixie Oct 2, 2020
Contributor

cc @HansMuller is it ok for this to return null?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.