Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd per locale Intl memoizer #504
Open
Conversation
| @@ -0,0 +1,14 @@ | |||
| type IntlCache = WeakMap<object, Record<string, object>>; | |||
macabeus
Jul 17, 2020
Contributor
Just a question: why is better to use a WeakMap here instead of just a plain object?
Just a question: why is better to use a WeakMap here instead of just a plain object?
Demivan
Jul 17, 2020
Author
I don't know :) Kept it as it is right now.
Seeing that map keys are Intl.NumberFormat and Intl.DateTimeFormat and will not be garbage collected it should be regular Map instead
I don't know :) Kept it as it is right now.
Seeing that map keys are Intl.NumberFormat and Intl.DateTimeFormat and will not be garbage collected it should be regular Map instead
Pike
Jul 30, 2020
Contributor
I didn't fully finish my doodling, but it seems that the keys are objects and not strings?
I didn't fully finish my doodling, but it seems that the keys are objects and not strings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This allows multiple bundles with same locale to share Intl cache