feat(primitive_types6): Add a test #548
Merged
Conversation
|
Did a force push to problem description and rewrite |
Co-authored-by: Annika <56906084+AnnikaCodes@users.noreply.github.com>
|
Thanks! |
fmoko
changed the title
|
@all-contributors please add @darnuria for code |
|
I've put up a pull request to add @darnuria! |
|
@all-contributors please add @AnnikaCodes for review |
|
I've put up a pull request to add @AnnikaCodes! |
|
let's try this again without conflicts @all-contributors please add @AnnikaCodes for review |
|
I've put up a pull request to add @AnnikaCodes! |
|
@all-contributors please add @AnnikaCodes for review |
|
I've put up a pull request to add @AnnikaCodes! |
catull
added a commit
to catull/rustlings
that referenced
this pull request
Oct 24, 2020
Co-authored-by: Annika <56906084+AnnikaCodes@users.noreply.github.com> Co-authored-by: fmoko <mokou@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
To keep constancy with
primitive_types4.rsI suggest to add a test inprimitive_types6.rsthis suggestion comes from my students because some students were just typing any numbers.Also added a little indication in order to avoid passing solution with just typing the number. Also it's possible to type out
numbers.???to avoid this possible unexpected outcome I got it in class this week.If it's not an issue or if this not merge-able in this state I am open to discussion! :)