Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChange ArrayEach CB Signature to Return Error #156
Conversation
Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)
vanackere
commented
Feb 19, 2020
|
@buger : I was in the process of writing the exact same pull request when I noticed this was already there... Any chance to have this merged ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jlhawn commentedNov 13, 2018
Description: Changes the callback function signature of
ArrayEachto return an error. It currently takes an error as input even thoughArrayEachnever passes a non-nil error into it. It should be more likeObjectEachwhich returns an error from its callback function.I had to fix
Dockerfileandbenchmark/benchmark_codecgen.goin order to get benchmarks to run.(...it makes this repository seem very under-maintained).
Benchmark before change: DID NOT WORK
Benchmark after change: