Skip to content

/ cz-cli Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Exit CLI with 1(as failed) when received SIGINT #736

Merged
merged 3 commits into from Oct 20, 2020
Merged

fix(cli): Exit CLI with 1(as failed) when received SIGINT #736

merged 3 commits into from Oct 20, 2020

Conversation

@hdmr14
Copy link
Contributor

@hdmr14 hdmr14 commented May 5, 2020

fix #688

commitizen always exit with 0(as succeeded) even if user inputs CTRL-C, it caused by Inquirer.js traps SIGINT.

In this PR, Fix issue by applying workaround which suggested in issue of Inquirer.js.

commitizen now exit with 1(as failed) when CTRL-C inputted.
hdmr14 added 2 commits May 1, 2020
@hdmr14
fix: Exit process as failed when catch SIGINT.
4515d85
@hdmr14
Merge branch 'master' of https://github.com/commitizen/cz-cli into fi…
cdf6a85 
…x-sigint-hook
@hdmr14 hdmr14 changed the title Fix sigint hook fix(cli): Exit CLI with 1(as failed) when received SIGINT. Jun 30, 2020
@hdmr14 hdmr14 changed the title fix(cli): Exit CLI with 1(as failed) when received SIGINT. fix(cli): Exit CLI with 1(as failed) when received SIGINT Jun 30, 2020
@dmwelch dmwelch self-assigned this Aug 21, 2020
@dmwelch dmwelch mentioned this pull request Aug 21, 2020
Closed
@dmwelch
Copy link
Contributor

@dmwelch dmwelch commented Aug 21, 2020

@hdmr14 Thanks for this PR! I want to get this merged as soon as possible so let me know what you think of the return code. Cheers!

dmwelch
dmwelch reviewed Aug 26, 2020
View changes
bin/git-cz.js Outdated Show resolved Hide resolved
@dmwelch
Exit on SIGINT with correct POSIX value
d43746b
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Sep 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@be08907). Click here to learn what that means.
The diff coverage is n/a.

@dmwelch dmwelch merged commit 95a20d4 into commitizen:master Oct 20, 2020
8 checks passed
@commitizen-bot
Copy link

@commitizen-bot commitizen-bot commented Oct 20, 2020

🎉 This PR is included in version 4.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmwelch dmwelch

Assignees

@dmwelch dmwelch

Labels
bug cli released
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

husky falls back to original git commit message prompt if I cancel when displaying commitizen prompt
4 participants
@hdmr14 @dmwelch @codecov-commenter @commitizen-bot