Skip to content

fix(vue): improve path matching when going back #22275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 13, 2020
Merged

fix(vue): improve path matching when going back #22275

merged 9 commits into from
Oct 13, 2020

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #22258

What is the new behavior?

  • Added additional path matching closer to what Ionic React does

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi changed the base branch from ionic-vue to master October 8, 2020 17:45
@liamdebeasi liamdebeasi linked an issue Oct 13, 2020 that may be closed by this pull request
bug: Vue fail to navigate with IonBackButton and default-href #22258
Closed
@github-actions github-actions bot added the package: vue @ionic/vue package label Oct 13, 2020
@liamdebeasi liamdebeasi merged commit b06ae16 into master Oct 13, 2020
@liamdebeasi liamdebeasi mentioned this pull request Oct 13, 2020
Closed
@liamdebeasi liamdebeasi deleted the tabs-back-stack branch October 13, 2020 20:05
TakumaKira pushed a commit to TakumaKira/ionic-framework that referenced this pull request Nov 13, 2020
@liamdebeasi
fix(vue): improve path matching when going back (ionic-team#22275)
0aa2fc5 
resolves ionic-team#22258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: vue @ionic/vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Vue fail to navigate with IonBackButton and default-href
1 participant
@liamdebeasi