Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRunning devtool tests against multiple versions of react #19912
Conversation
|
Hi @MoSattler! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
MoSattler
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5c6c9b3:
|
MoSattler
changed the title
MoSattler
force-pushed the
MoSattler:circleci
branch
10 times, most recently
from
78707ee
to
04db806
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
MoSattler
force-pushed the
MoSattler:circleci
branch
5 times, most recently
from
438fe78
to
d67d8f3
MoSattler
changed the title
| @@ -1,4 +1,4 @@ | |||
| version: 2 | |||
| version: 2.1 | |||
MoSattler
Sep 26, 2020
Author
CircleCI's job matrix only works in >2.1
CircleCI's job matrix only works in >2.1
| - checkout | ||
| - attach_workspace: *attach_workspace | ||
| - *restore_node_modules | ||
| - run: yarn add react@<< parameters.react-version >> react-dom@<< parameters.react-version >> react-is@<< parameters.react-version >> react-test-renderer@<< parameters.react-version >> --modules-folder build/node_modules -W |
MoSattler
Sep 26, 2020
Author
there might be a cleaner version of achieving this.
there might be a cleaner version of achieving this.
| - '15.0.0' | ||
| - '15.0.1' | ||
| - '15.0.2' | ||
| - '15.1.0' | ||
| - '15.2.0' | ||
| - '15.2.1' | ||
| - '15.3.0' | ||
| - '15.3.1' | ||
| - '15.3.2' | ||
| - '15.4.0' | ||
| - '15.4.1' | ||
| - '15.4.2' | ||
| - '15.5.0' | ||
| - '15.5.1' | ||
| - '15.5.2' | ||
| - '15.5.3' | ||
| - '15.5.4' | ||
| - '15.6.0' | ||
| - '15.6.1' | ||
| - '15.6.2' | ||
| - '16.0.0' | ||
| - '16.1.0' | ||
| - '16.1.1' | ||
| - '16.2.0' | ||
| - '16.3.0' | ||
| - '16.3.1' | ||
| - '16.3.2' | ||
| - '16.4.0' | ||
| - '16.4.1' | ||
| - '16.4.2' | ||
| - '16.5.0' | ||
| - '16.5.1' | ||
| - '16.5.2' | ||
| - '16.6.0' | ||
| - '16.6.1' | ||
| - '16.6.3' | ||
| - '16.7.0' | ||
| - '16.8.0' | ||
| - '16.8.1' | ||
| - '16.8.2' | ||
| - '16.8.3' | ||
| - '16.8.4' | ||
| - '16.8.5' | ||
| - '16.8.6' | ||
| - '16.9.0' | ||
| - '16.10.0' | ||
| - '16.10.1' | ||
| - '16.10.2' | ||
| - '16.11.0' | ||
| - '16.12.0' | ||
| - '16.13.0' | ||
| - '16.13.1' |
MoSattler
Sep 26, 2020
Author
Probably an overkill
Probably an overkill
Trying to fix #19371. I have trouble getting the tests to pass. Some of that might be because of new features, which somehow needs to be gated against, as suggested by @bvaughn. I believe other test failures might be coupling to the newer code, but I am not sure about this.