Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes to Rails 3 deprecation warnings #31
Conversation
|
I spoke too soon - the plugin works in both Ruby 1.8.7 / Rails 2.3.8 and Ruby 1.9.2 / Rails 3.0.1 and the tests pass in Ruby 1.8.7 but they crash in Ruby 1.9.2 - the issue is a Gem::LoadError /Users/jones/.rvm/rubies/ruby-1.9.2-p0/lib/ruby/1.9.1/rubygems.rb:238:in `activate': can't activate actionpack (= 2.3.8, runtime) for [], already activated actionpack-3.0.1 for Not sure what the issue is. I am running ruby 1.9.2 under rvm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi
I've fixed a couple of Deprecation warnings in Rails 3.0.1/Ruby 1.9.2 by moving the require on the controller_extension into the top-level init.rb and using Rails.env instead of RAILS_ENV.
I had to change the test_helper to fake a Rails.env method. It passes tests in Ruby 1.8.7/Rails 2.3.8 and Ruby 1.9.2/Rails 3.0.1
Hope you can merge them into the plugin
--Rob Jones