Skip to content

/ InAppPy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend status code for validation of receipt for AppStore #68

Open
wants to merge 1 commit into
base: master
from
Open

Extend status code for validation of receipt for AppStore #68

wants to merge 1 commit into from

Conversation

@DmytroLitvinov
Copy link

@DmytroLitvinov DmytroLitvinov commented Aug 10, 2020

Description

This PR fix issue #67 for extending status code of response.
Also, I would like to propose to refactor exception message to the same as in the Apple documentation.

Related Issue

#67

Motivation and Context

We need to apply this change and push to pypi because we know what these statuses mean for us (related to

InAppPy/inapppy/appstore.py

Line 94 in f2338fc

error = api_result_errors.get(status, InAppPyValidationError("Unknown API status"))
)

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@DmytroLitvinov
Extend status code for validation of receipt for AppStore
Verified
This commit was signed with a verified signature.
DmytroLitvinov Dmytro Litvinov
GPG key ID: 805E7168ADCA1743 Learn about signing commits
Loading status checks…
683ce6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@DmytroLitvinov
You can’t perform that action at this time.