Skip to content

/ ko

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix things pointed out by golangci-lint #222

Merged
merged 2 commits into from Oct 13, 2020
Merged

Fix things pointed out by golangci-lint #222

merged 2 commits into from Oct 13, 2020

Conversation

@markusthoemmes
Copy link
Contributor

@markusthoemmes markusthoemmes commented Oct 13, 2020

This fixes the linting issues as pointed out by golangci-lint. Also reduces its config a bit as most of it isn't necessary here.
@markusthoemmes
Fix things pointed out by golangci-lint
Loading status checks…
695b39f
@markusthoemmes
Reduce config a bit
Loading status checks…
b5daa6c
@markusthoemmes markusthoemmes mentioned this pull request Oct 13, 2020
Open
@ImJasonH
ImJasonH approved these changes Oct 13, 2020
View changes
Copy link
Member

@ImJasonH ImJasonH left a comment

Thanks for fixing these! 🎉
@ImJasonH ImJasonH merged commit 2c4d755 into google:master Oct 13, 2020
10 checks passed
10 checks passed
Boilerplate Check (go) Boilerplate Check (go)
Details
Build (1.15.x, ubuntu-latest)
Details
Auto-format and Check Auto-format and Check
Details
Do Not Submit
Details
Unit Tests (1.15.x, ubuntu-latest) Unit Tests (1.15.x, ubuntu-latest)
Details
Verify Deps and Codegen (1.15.x, ubuntu-latest)
Details
Boilerplate Check (sh) Boilerplate Check (sh)
Details
Lint Lint
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImJasonH ImJasonH

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@markusthoemmes @ImJasonH
You can’t perform that action at this time.