Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport .ko.yaml while in subdir #172
Comments
|
Hey @mattmoor I'd like to take this one up but before that I want to clarify with you. Let's say I have this structure:
Are we expecting to use |
|
I think this could spiral quickly, so I think as a first increment let's start with three simple pieces:
I think this balances clarity and simplicity. WDYT? |
|
I'm totally behind reading from only one |
|
I'd probably do the simple thing: keep going until you hit the root, or start getting permissions errors |
One edge case that might end up confusing to end users (small problem since we're logging the location out but I'd still like to raise it): Say I have
Now if I run |
Today if I invoke
ko apply -f foo/while in a subdirectorybar/then it is possible that a.ko.yamlfile that's a sibling ofbar/won't be picked up because we (currently) only look at siblings offoo/.Fortunately,
AddConfigPathseems to support multiple invocations, so we can crawl the directory hierarchy from the current working directory to populate the path.I think we want this here:
ko/pkg/commands/config.go
Line 104 in d45c527