Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noActivity and IsSystemAlertWindow ViewInteraction #627

Conversation

@darran-kelinske-fivestars
Copy link

@darran-kelinske-fivestars darran-kelinske-fivestars commented May 4, 2020

Overview

I don't know the appropriate structure/design to implement this functionality, but wanted to submit what I need. I can then refactor it to match the desired design - One idea is to create a

onWebView static method that takes flags for noActivity and perhaps a ViewInteraction, but I don't think there is a ViewInteraction function that can take a generic ViewInteraction - I can add that too

Proposed Changes

I need the ability to get access to a WebInteraction for a webview hosted in a view created by a service.

@googlebot
Copy link
Collaborator

@googlebot googlebot commented May 4, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label May 4, 2020
dazza5000 and others added 2 commits May 4, 2020
@googlebot
Copy link
Collaborator

@googlebot googlebot commented May 6, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@darran-kelinske-fivestars
Copy link
Author

@darran-kelinske-fivestars darran-kelinske-fivestars commented Jun 23, 2020

Is this a reasonable PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.