Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes bug in wasm-builder with cargo publish #7299
Merged
Conversation
There was a bug in wasm-builder which resulted in generating a `Cargo.lock` in the project directory because of running `cargo metadata`. This resulted in commands like `cargo publish` to fail (if there was no `Cargo.lock` before building), because it checks that the project directory isn't modified.
|
New version needs to be published and should be good to merge afterwards. |
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
bkchr
merged commit 8efe8b8
into
master
20 checks passed
20 checks passed
continuous-integration/gitlab-check-polkadot-companion-build
Build stage: build; status: success
Details
continuous-integration/gitlab-check-polkadot-companion-status
Build stage: build; status: success
Details
continuous-integration/gitlab-test-frame-examples-compile-to-wasm
Build stage: test; status: success
Details
continuous-integration/gitlab-test-prometheus-alerting-rules
Build stage: test; status: success
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
There was a bug in wasm-builder which resulted in generating a
Cargo.lockin the project directory because of runningcargo metadata. This resulted in commands likecargo publishto fail (ifthere was no
Cargo.lockbefore building), because it checks that theproject directory isn't modified.
Fixes: #7116