dependant list added. #319

jtprof · 2020-06-30T08:35:19Z

The values in the list, which are available to a user choice, depends on chosen values of other parameters.
The relations should be set in configuration manually.
Parameter configuration window in admin has not been changed.

The feature useful to avoid user to set inadmissible values combination.

Example in parameterized.json:
'aduld dogs food' in "Dependant List" variable is unavailable while "Cats", "Rats" or "Squirrel" is chosen in "Simple List" variable.

… user choice, depends on choosen values of othe parameters. The relations shoud be set in configuration manually. Parameter configuration window in admin has not been changed.

jtprof · 2020-07-01T10:52:18Z

A far as i have seen CI test failed due to f-string syntax (PEP 498).
May be it's good idea to increase project's requirements to Python 3.6 ?

bugy

There are a couple of minor comments (mostly styling or wording). Great job!

bugy · 2020-07-05T18:53:47Z

src/config/constants.py

@@ -1,4 +1,6 @@
 PARAM_TYPE_SERVER_FILE = 'server_file'
 PARAM_TYPE_MULTISELECT = 'multiselect'
+PARAM_TYPE_LIST = 'list'
+PARAM_TYPE_DEPENDANT_LIST = 'dependant_list'


I think this is not exactly "param type" because the type is still "list" (according to the example, you added)

Formally you are right. But

Other types (such 'text', 'int', etc.) don't have its own constants, so the file needs to refactor

I believe the issue should been separated to its own type, so, it's for future use

Can we call it "list subtype" or smth like this? :)
I raised this concern only because I was confused while reading the code

bugy · 2020-07-05T18:53:47Z

samples/configs/parameterized.json

+      "name": "Dependant List",
+      "param": "--dependant_list",
+      "type": "list",
+      "description": "The avalible values depends on other variables",


Could you fix typos please? :) "Available" "depend"

bugy · 2020-07-05T18:53:47Z

src/config/script/list_values.py

+            for key in self._values_conditions[e]:
+                pvalue = parameter_values.get(key)                
+                if not is_empty(pvalue):
+                    if not(pvalue in self._values_conditions[e][key] ):


could you change it to not in, please?

bugy · 2020-07-05T18:53:47Z

src/config/script/list_values.py

+        self._availible_values = set()
+        deny_values = set()
+
+        for e in self._values_conditions:


Could you rename e to something like possible_value, otherwise it's pretty hard to read

bugy · 2020-07-05T18:53:47Z

src/config/script/list_values.py

@@ -52,6 +52,46 @@ def __init__(self, script) -> None:
    def get_values(self, parameter_values):
        return self._values

+class DependantValuesProvider(ValuesProvider):


Would you mind adding a couple of tests for this class? Specifically for get_values method

bugy · 2020-07-05T18:55:40Z

Hi @jtprof Thanks a lot for the PR! and really sorry for the late response, it was quite busy week for me.
I left a couple of small comments for the code.

Regarding python 3.6: I would love to use f-strings also, but I think there are still some people using python 3.5, so I would prefer to keep 3.5 compability for now, especially considering that 3.5 is still "active" python version https://devguide.python.org/#status-of-python-branches

jtprof · 2020-07-06T18:25:35Z

Hi @jtprof Thanks a lot for the PR! and really sorry for the late response, it was quite busy week for me.
No pressure.

I left a couple of small comments for the code.
I will fix.

Regarding python 3.6: I would love to use f-strings also, but I think there are still some people using python 3.5, so I would prefer to keep 3.5 compability for now, especially considering that 3.5 is still "active" python version https://devguide.python.org/#status-of-python-branches

2020-09-13 'End-of-life'. It's so close.

…'ipv6', 'int' types variable have been added as composed by script.

bugy · 2020-07-08T12:16:20Z

.gitignore

+venv/
+
+conf/rediska.conf


I think those are not needed

bugy · 2020-07-08T12:16:20Z

src/config/constants.py

@@ -1,4 +1,6 @@
 PARAM_TYPE_SERVER_FILE = 'server_file'
 PARAM_TYPE_MULTISELECT = 'multiselect'
+PARAM_TYPE_LIST = 'list'
+PARAM_TYPE_DEPENDANT_LIST = 'dependant_list'


Can we call it "list subtype" or smth like this? :)
I raised this concern only because I was confused while reading the code

Enable searchbox support on multiselect combobox

bugy · 2020-08-15T10:10:12Z

HI @jtprof, sorry for being inactive here.

I started working on refactoring for this PR and thought how to make configuration of conditional values a bit simpler (at the moment it has multiple nested levels) and more generic (so that you can use patterns, comparison, etc.).
In the end, I came up with idea of writing simple conditions, like "Dog food": "${param1} in ['a', 'b', 'c'] and ${param2} > 0"
But then I realize, that this is already covered by a possibility to specify scripts. So instead of writing complicated config, you can always write a script and pass parameter values there. And then this script will be responsible for deciding which values are supported.
I understand, that for simple cases, which you try to cover here, a script might be overhead, but as for me, it still keeps config cleaner and reduces code complexity of script server

dependant_list added. The values in the list, which are avalible to a…

Loading status checks…

c47f9b4

… user choice, depends on choosen values of othe parameters. The relations shoud be set in configuration manually. Parameter configuration window in admin has not been changed.

bugy requested changes Jul 5, 2020

View changes

Compose value from script to text fields

f16365a

Bug in default value for 'text' fields has been fixed. 'ip', 'ipv4', …

aa795da

…'ipv6', 'int' types variable have been added as composed by script.

bugy requested changes Jul 8, 2020

View changes

Daniel Rehelis and others added 3 commits Jul 13, 2020

Enable searchbox support on multiselect combobox

1423868

Merge pull request #1 from jtprof/enable_search_on_multiselect

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

ad7f427

Enable searchbox support on multiselect combobox

Merge branch 'master' into master

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

b9c3f94

bugy / script-server

dependant list added. #319

dependant list added. #319

jtprof commented Jun 30, 2020

jtprof commented Jul 1, 2020

bugy left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bugy commented Jul 5, 2020

jtprof commented Jul 6, 2020

This comment has been minimized.

This comment has been minimized.

bugy commented Aug 15, 2020

		venv/

		conf/rediska.conf

bugy / script-server

Join GitHub today

dependant list added. #319

dependant list added. #319

Conversation

jtprof commented Jun 30, 2020

jtprof commented Jul 1, 2020

bugy left a comment

This comment has been minimized.

bugy Jul 5, 2020 Owner

This comment has been minimized.

jtprof Jul 6, 2020 Author Contributor

This comment has been minimized.

bugy Jul 8, 2020 Owner

This comment has been minimized.

bugy Jul 5, 2020 Owner

This comment has been minimized.

bugy Jul 5, 2020 Owner

This comment has been minimized.

bugy Jul 5, 2020 Owner

This comment has been minimized.

bugy Jul 5, 2020 Owner

bugy commented Jul 5, 2020

jtprof commented Jul 6, 2020

This comment has been minimized.

bugy Jul 8, 2020 Owner

This comment has been minimized.

bugy Jul 8, 2020 Owner

bugy commented Aug 15, 2020

Essential cookies

Always active

Analytics cookies

bugy Jul 5, 2020
Owner

jtprof Jul 6, 2020
Author Contributor

bugy Jul 8, 2020
Owner

bugy Jul 5, 2020
Owner

bugy Jul 5, 2020
Owner

bugy Jul 5, 2020
Owner

bugy Jul 5, 2020
Owner

bugy Jul 8, 2020
Owner

bugy Jul 8, 2020
Owner