Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upcdk-cloudfront-authorization: Skip basic auth if client secret is undefined #55
Conversation
packages/cdk-cloudfront-authorization/src/lambdas/refresh-auth/index.ts
Outdated
Show resolved
Hide resolved
|
Implemented proposed solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi,
Thank you for providing this library.
I used the package cdk-cloudfront-authorization.
When the authentication token was expired, the refresh auth action wasn't successfull. The error invalid_client occurred.
My cognito app client doesn't use client secrets. However, an authorization header was sent to cognito.
The authorization header contained
1234567890:undefined. Therefore, I've implemented an additional check to skip the authorization header if the value is undefined.Best regards,
Julian