Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process = await nursery.start(run_process, ...) #1568

Open
wants to merge 3 commits into
base: master
from

Conversation

@njsmith
Copy link
Member

@njsmith njsmith commented Jun 2, 2020

Fixes #1104

Todo:

  • docs
  • tests
  • newsfragment
  • deprecate Process.aclose
  • move open_process to trio.lowlevel

I think this gets the basic semantics right? Still need to do
everything around that though.

@codecov
Copy link

@codecov codecov bot commented Jun 2, 2020

Codecov Report

Merging #1568 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1568      +/-   ##
==========================================
+ Coverage   99.68%   99.69%   +0.01%     
==========================================
  Files         110      111       +1     
  Lines       13498    13871     +373     
  Branches     1027     1059      +32     
==========================================
+ Hits        13455    13829     +374     
+ Misses         28       27       -1     
  Partials       15       15              
Impacted Files Coverage Δ
trio/_subprocess.py 100.00% <100.00%> (ø)
trio/lowlevel.py 100.00% <0.00%> (ø)
trio/_core/__init__.py 100.00% <0.00%> (ø)
trio/_core/_io_epoll.py 100.00% <0.00%> (ø)
trio/_core/_wakeup_socketpair.py 100.00% <0.00%> (ø)
trio/_core/tests/test_guest_mode.py 100.00% <0.00%> (ø)
trio/_core/_run.py 99.76% <0.00%> (+0.02%) ⬆️
trio/_core/_io_windows.py 98.57% <0.00%> (+0.03%) ⬆️
trio/_core/_ki.py 100.00% <0.00%> (+1.49%) ⬆️
trio/_core/_io_kqueue.py 85.00% <0.00%> (+1.98%) ⬆️
@oremanj
Copy link
Member

@oremanj oremanj commented Jun 4, 2020

This looks like a good approach so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.