Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Compact json download #820
Merged
Conversation
|
fixes #772 |
| @@ -102,7 +102,7 @@ class ExportModal extends React.PureComponent<Props, State> { | |||
| content.config = mergeConfig({}, this.props.config, content.config); | |||
| } | |||
|
|
|||
| const blob = new Blob([JSON.stringify(content, null, 2)], { | |||
| const blob = new Blob([JSON.stringify(content, null, 0)], { | |||
domoritz
Oct 4, 2020
Member
Please use json-stringify-pretty-compact instead.
Please use json-stringify-pretty-compact instead.
ashu8912
Oct 4, 2020
Author
Member
aah nice we want best of both the worlds, i will add the fix
aah nice we want best of both the worlds, i will add the fix
domoritz
Oct 4, 2020
Member
We don't need any arguments anymore. Look at other uses of json-stringify-pretty-compact.
We don't need any arguments anymore. Look at other uses of json-stringify-pretty-compact.
We right now use a whitespace of the factor 2 while stringifying the json download, The whitespaces in the json increases the downloaded json file size, we rather would want to make the json as compact as possible thus reducing the space factor within the json to 0.
|
@domoritz fixed and tested as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.