plafer
Follow
Highlights
- Pro
Pinned
507 contributions in the last year
Contribution activity
February 2023
Created 11 commits in 3 repositories
Created a pull request in cosmos/ibc-rs that received 25 comments
Finish adapting unit tests to new API
Closes: #41
PR author checklist:
Added changelog entry, using unclog.
Added tests.
Linked to GitHub issue.
Updated code comments and document…
+2,030
−2,367
•
25
comments
Opened 7 other pull requests in 2 repositories
cosmos/ibc-rs
6
merged
cosmos/ibc-proto-rs
1
merged
Reviewed 17 pull requests in 2 repositories
cosmos/ibc-rs
15 pull requests
-
Add an implementation of "validate_self_client" for
MockContext - Finish adapting unit tests to new API
- Add a docstring and rename the "validate_self_client" argument for better
- Refactor connection handler unit tests to adapt with new API
- Add conversion from &IbcEvent to abci::Event
-
Fix error todo!()s wherever the tendermint client calls
consensus_state -
Organize host chain methods under a new
HostChainContexttrait -
Prepare to move test code to
Validation/ExecutionContextAPI - Refactor store_* and get_* methods to take *Path structs instead
-
Upgrade
ibc-protoandspdeps for no-std support -
Fix issue with
PacketReceiptNotFounderror returned byget_packet_receiptmethod -
Fix issue with the error variant of
new_check_header_and_updatemethod -
Finish implementation of
Validation/ExecutionContext - Bump substrate versions
-
Implement
verify_upgrade_and_update_statefor Tendermint Client
informalsystems/basecoin-rs
2 pull requests
Created an issue in cosmos/ibc-rs that received 3 comments
Convert tests to use rstest crate
We should move towards using rstest crate to make tests more easily readable and maintainable.
3
comments
Opened 18 other issues in 2 repositories
cosmos/ibc-rs
12
open
4
closed
- implement missing timeout packet test
-
Adapt
send_packet()andsend_transfer()API to - Define testing strategy
-
MockContext::validate_self_client()should have an implementation - Refactor unit tests
-
Use
rstestto rewriterouting_module_and_keepers()test -
Test NO-OP paths for packet acks,
RecvPacketand timeouts -
ValidationContext::host_timestamp()should notexpect() -
Allow conversion from
&IbcEventtoabci::Event -
Remove
val_exec_ctxfeature flag -
Convert all test code to test the
Validation/ExecutionContextAPI -
Enable Github "merge queue" on
main -
Remove
todo!()s for tendermintClientState -
Add
dispatch()function forVal/ExecContext -
Remove
ChannelEnd::order_matches() - Packet timeout, TimeoutOnClose, Acknowledgement handlers NOOP functionality missing