Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdjusts Southeast Asian countries list #322
Open
Conversation
* Adds h3 headings to Mainland / Maritime sub-regions * Each country is now a list item element
This commit enhances the layout of the countries listed in the definition for Southeast Asian by using two columns. Future definitions can use this new layout by following this Markdown example: ### Sandwich Condiments - Mayonaise - Mustard ### Pasta Sauces - Marinara - Pesto
|
Reviewers be aware: #321 has another approach to solving this as well! |
|
One comment. |
| @@ -62,6 +62,11 @@ | |||
| // padding-left: 1rem; | |||
| grid-column: 2; | |||
| } | |||
|
|
|||
| & h3 ~ ul { | |||
| border-bottom: 0.1rem solid lightgrey; | |||
tatianamac
Oct 7, 2020
Collaborator
Suggested change
border-bottom: 0.1rem solid lightgrey;
border-bottom: 0.1rem solid lightgrey;
Could we use one of our sass variable colours here so that the change will respect light-dark mode?
Suggested change
| border-bottom: 0.1rem solid lightgrey; | |
| border-bottom: 0.1rem solid lightgrey; |
Could we use one of our sass variable colours here so that the change will respect light-dark mode?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR will close #271
This enhances the layout of the countries listed in the definition for Southeast Asian by using two columns.
Screenshots before and after:
First, I changed the markdown to have better ease of reading:
Then, I added new CSS rules.
Future definitions can use this new layout by following this Markdown example:
Or this HTML example: