Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React StrictMode Globally #1549

Open
wants to merge 1 commit into
base: master
from

Conversation

@alexpelan
Copy link
Contributor

@alexpelan alexpelan commented Aug 21, 2018

Seems to work, we get some console errors now.

Fixes: #1403

Seems to work, we get some console errors now.

Fixes: #1403
@alexpelan alexpelan requested a review from outoftime Aug 21, 2018
Copy link
Contributor

@outoftime outoftime left a comment

@alexpelan let’s fix the errors?

@alexpelan
Copy link
Contributor Author

@alexpelan alexpelan commented Aug 21, 2018

@outoftime
Copy link
Contributor

@outoftime outoftime commented Aug 28, 2018

@alexpelan wait I swear I remember a thorough writeup about how it’s not really possible to fix the StrictMode errors until a new version of, I think, redux comes out? Where was that? Or was I dreaming?

Anywho, assuming I was not dreaming, I’ll just merge this once we no longer have library dependencies in the way ; )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.