Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd React StrictMode Globally #1549
Open
Conversation
Seems to work, we get some console errors now. Fixes: #1403
|
@alexpelan let’s fix the errors? |
|
@outoftime ok |
|
@alexpelan wait I swear I remember a thorough writeup about how it’s not really possible to fix the StrictMode errors until a new version of, I think, redux comes out? Where was that? Or was I dreaming? Anywho, assuming I was not dreaming, I’ll just merge this once we no longer have library dependencies in the way ; ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Seems to work, we get some console errors now.
Fixes: #1403