Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes nextcloud/docker#1088 #1257
Open
Conversation
| local varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") | ||
| local fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") | ||
| local varValue="`env | grep -E \"^${var}=\" | sed -E -e \"s/^${var}=//\"`" | ||
| local fileVarValue="`env | grep -E \"^${fileVar}=\" | sed -E -e \"s/^${fileVar}=//\"`" |
NeroBurner
Oct 14, 2020
Contributor
why replace the newer $() syntax with the (what I believe) older and less readable ` syntax?
why replace the newer $() syntax with the (what I believe) older and less readable ` syntax?
nicobo
Oct 15, 2020
Author
@NeroBurner I just tried to replace this at first to see if it was causing the strange behavior. You can probably put them back.
BTW I find backquotes way more readable 😉
@NeroBurner I just tried to replace this at first to see if it was causing the strange behavior. You can probably put them back.
BTW I find backquotes way more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes "NEXTCLOUD_ADMIN_PASSWORD can't have spaces"
By double-quoting the buggy lines...