Skip to content

/ sentry-java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Action to validate presence of a changelog in a PR #962

Merged
merged 1 commit into from Oct 2, 2020
Merged

Add GitHub Action to validate presence of a changelog in a PR #962

merged 1 commit into from Oct 2, 2020

Conversation

@Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Oct 2, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

GitHub Actions workflow that runs on PRs and fails if CHANGELOG.md was not modified as part of that PR. Should be merged after #961.

💡 Motivation and Context

#960

💚 How did you test it?

I copy-pasted it from sentry-dotnet where it's already working

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

Related to #960 #961
@Tyrrrz
Add GitHub Action to validate presence of a changelog in a PR
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4f163f3
@Tyrrrz Tyrrrz requested review from bruno-garcia and marandaneto as code owners Oct 2, 2020
@marandaneto marandaneto merged commit c322651 into getsentry:main Oct 2, 2020
5 of 6 checks passed
5 of 6 checks passed
validate-changelog validate-changelog
Details
Validation
Details
Build Job ubuntu-latest
Details
Build Job macos-latest
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Tyrrrz Tyrrrz deleted the Tyrrrz:patch-2 branch Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia

@marandaneto marandaneto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Tyrrrz @marandaneto
You can’t perform that action at this time.