Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uplib: fix duplicate logic in stream destroy #35727
Open
+16
−22
Conversation
|
Review requested: |
Codecov Report
@@ Coverage Diff @@
## master #35727 +/- ##
==========================================
- Coverage 96.40% 96.40% -0.01%
==========================================
Files 222 223 +1
Lines 73682 73679 -3
==========================================
- Hits 71033 71029 -4
- Misses 2649 2650 +1
Continue to review full report at Codecov.
|
|
The subsystem in commit title should be |
Fix duplicate logic in stream destroy as the same logic is being shared across methods and thus can be encapsulated into a single method.
yashLadha
force-pushed the
yashLadha:fix_duplicate_logic_stream_destroy
branch
from
fb42577
to
464d7c6
|
Updated @lpinca |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fix duplicate logic in stream destroy as the same logic is being shared
across methods and thus can be encapsulated into a single method.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes