Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new laravel versions and fixed scraper #1228

Merged
merged 3 commits into from Nov 14, 2020

Conversation

@rickmacgillis
Copy link
Contributor

@rickmacgillis rickmacgillis commented May 18, 2020

  • Updated the versions and releases in the scraper file
  • Ensured the license is up-to-date and that the documentation's entry in the array in about_tmpl.coffee matches it's data in self.attribution
  • Ensured the icons and the SOURCE file in public/icons/your_scraper_name/ are up-to-date if the documentation has a custom icon
  • Ensured self.links contains up-to-date urls if self.links is defined
  • Tested the changes locally to ensure:
    • The scraper still works without errors
    • The scraped documentation still looks consistent with the rest of DevDocs
    • The categorization of entries is still good

I've updated the Laravel scraper to handle the new website format on their site, and to add the following versions. The scraper is still backwards compatible with older versions, as they all use the same site layout.

  • Laravel 5.8
  • Laravel 6.0
  • Laravel 7.0
@Rai
Copy link

@Rai Rai commented May 30, 2020

Would be great to have this...

Rick Mac Gillis and others added 3 commits May 18, 2020
Signed-off-by: Rick Mac Gillis <noreply@rickmacgillis.com>
lib/docs/scrapers/php.rb Outdated Show resolved Hide resolved
@simon04 simon04 force-pushed the rickmacgillis:patch2 branch from 2e8d923 to daaf1d6 Nov 14, 2020
@rickmacgillis rickmacgillis requested a review from freeCodeCamp/devdocs as a code owner Nov 14, 2020
Copy link
Contributor

@simon04 simon04 left a comment

Awesome, thank you! I've updated the release numbers and added version 8.

@simon04 simon04 self-assigned this Nov 14, 2020
@simon04 simon04 merged commit b503241 into freeCodeCamp:master Nov 14, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.