Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake body field optional #137
Merged
Conversation
| .map(str::to_lowercase) | ||
| .filter(|word| !stopwords.contains(word)) | ||
| .collect::<HashSet<String>>(), | ||
| content.map(|content| { |
mre
Oct 22, 2020
Collaborator
Nice pattern! I didn't know that Option.map() would leave the None case untouched.
Nice pattern! I didn't know that Option.map() would leave the None case untouched.
felipe-fg
Oct 22, 2020
Author
Contributor
Yeah, it's pretty nice to use Option on things like this. (Same for Result)
Yeah, it's pretty nice to use Option on things like this. (Same for Result)
|
Looks great. Thanks for the PR! |
mre
added a commit
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Post body now is an optional field.
I have changed the test because there is a case mismatch when transforming words before adding to filter.
Resolves #117.