Skip to content

/ Go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files refactored for lint compliance. Tests and benchmarks added. #221

Merged
merged 2 commits into from Oct 12, 2020
Merged

Files refactored for lint compliance. Tests and benchmarks added. #221

merged 2 commits into from Oct 12, 2020

Conversation

@Mystigan
Copy link
Contributor

@Mystigan Mystigan commented Oct 12, 2020

Signed-off-by: Jobin John jobin1094@gmail.com

Changes made:

  • For prime check:
    - Refactored prime check folder and package names.
    - Cleaned test file.
    - Added benchmarks for both approaches.
  • For GCD
    - Refactored folder and package names.
    - Added tests and benchmark.
  • For fastExponent
    - Refactored folder and package names.
    - Some modifications made to fix golint warnings.
    - Added tests and benchmarks.
  • Updated CI lint yaml file. Added individual entries for folders temporarily because:
    • The sieve program doesn't make sense to me and nor does it run. Need some help fixing it.
    • Currently, I have moved it into a folder of its own and bypassed linting for it using " || true".
    • Once this is fixed, individual yaml entries can be replaced with a single recursive entry.

Fixes part of #145
Mystigan added 2 commits Oct 12, 2020
@Mystigan
Files refactored for lint compliance. Tests and benchmarks added.
b9e84b5 
Signed-off-by: Jobin John <jobin1094@gmail.com>
@Mystigan
Removed a stray quote.
Loading status checks…
9e6a93c 
Signed-off-by: Jobin John <jobin1094@gmail.com>
@Mystigan Mystigan requested a review from vedantmamgain Oct 12, 2020
@Mystigan Mystigan mentioned this pull request Oct 12, 2020
Open
2 of 11 tasks complete
@vedantmamgain
vedantmamgain reviewed Oct 12, 2020
View changes
Copy link
Contributor

@vedantmamgain vedantmamgain left a comment

Squash the commits before we merge this. Everything else LGTM.
@Mystigan
Copy link
Contributor Author

@Mystigan Mystigan commented Oct 12, 2020

Thanks @vedantmamgain . Merging changes(commits squashed) and adding hacktoberfest-accepted label.
@Mystigan Mystigan merged commit 4c3473d into TheAlgorithms:master Oct 12, 2020
1 check passed
1 check passed
golangci-lint golangci-lint
Details
@cclauss
cclauss reviewed Oct 14, 2020
View changes
Copy link
Member

@cclauss cclauss left a comment

LGTM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

@vedantmamgain vedantmamgain

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Mystigan @cclauss @vedantmamgain
You can’t perform that action at this time.