Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure primary content areas wrapped in main landmark element #3340

Merged
merged 8 commits into from Feb 17, 2021

Conversation

@jendowns
Copy link
Contributor

@jendowns jendowns commented Aug 16, 2020

Description

Hey everyone!

I noticed that the pages on the site are not wrapped in a <main> sectioning element, so the goal of this PR is to ensure that each page includes this semantic markup. Including a <main> landmark on a page improves accessibility by helping assistive tech quickly identify the primary content of the page.

Additional resources:

Please let me know if you have any questions or concerns about this change! Or if I missed a page. 😅

jendowns added 4 commits Aug 16, 2020
nschonni and others added 2 commits Oct 15, 2020
@XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Feb 14, 2021

This should be good to go; I don't see any CSS selectors to break after a quick look.

@MaledongGit
Copy link
Contributor

@MaledongGit MaledongGit commented Feb 17, 2021

Thanks for your contribution @jendowns!

@MaledongGit MaledongGit merged commit 9305e9d into nodejs:master Feb 17, 2021
1 check passed
1 check passed
test
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants