Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: punycode alternative name collision #35744

Open
whymarrh opened this issue Oct 21, 2020 · 0 comments
Open

doc: punycode alternative name collision #35744

whymarrh opened this issue Oct 21, 2020 · 0 comments
Labels
doc

Comments

@whymarrh
Copy link

@whymarrh whymarrh commented Oct 21, 2020

📗 API Reference Docs Problem

  • Version: v12.19.0 LTS
  • Platform: Darwin x86_64
  • Subsystem: punycode

Location

Section of the site where the content exists

Affected URL(s):

Description

Concise explanation of the problem

The punycode module docs note that it is deprecated and suggest using Punycode.js as an alternative:

The version of the punycode module bundled in Node.js is being deprecated.
In a future major version of Node.js this module will be removed. Users
currently depending on the punycode module should switch to using the
userland-provided Punycode.js module instead.

[…]

The punycode module is a third-party dependency used by Node.js and
made available to developers as a convenience. Fixes or other modifications to
the module must be directed to the Punycode.js project.

The alternative suggested is published as punycode on npm and thus its name is shadowed by the bundled version. A workaround is required to use the third-party module in place of the bundled module (see bestiejs/punycode.js#79 and bestiejs/punycode.js#113).

The API docs should either document the workaround required to use the suggested alternative, not suggest an alternative, or suggest an alternative that doesn't require a workaround.


  • I would like to work on this issue and
    submit a pull request.
@whymarrh whymarrh added the doc label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.