Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_iterator doesn't return the last chunk #35789

Open
mmomtchev opened this issue Oct 24, 2020 · 1 comment · May be fixed by #35798
Open

async_iterator doesn't return the last chunk #35789

mmomtchev opened this issue Oct 24, 2020 · 1 comment · May be fixed by #35798

Comments

@mmomtchev
Copy link
Contributor

@mmomtchev mmomtchev commented Oct 24, 2020

  • Version: master with QUIC
  • Platform: Linux
  • Subsystem: stream

What steps will reproduce the bug?

node test/parallel/test-quic-simple-server-uni.js

How often does it reproduce? Is there a required condition?

QUIC must be enabled

Additional information

node/lib/internal/streams/readable.js

Line 1098 in 7083425

const chunk = stream.destroyed ? null : stream.read();

This line, committed 10 days ago, is the culprit, removing the stream.destroyed condition makes it work
This happens when the stream has been asynchronously closed by the time the last read call is made
@mmomtchev
Copy link
Contributor Author

@mmomtchev mmomtchev commented Oct 24, 2020

@ronag
mmomtchev added a commit to mmomtchev/node that referenced this issue Oct 25, 2020
@mmomtchev
stream: fix async iter not reading last chunk on close
01f0d72 
The async iterator can sometimes miss the last chunk
when there has been an asynchronous event
and a null chunk as used by
test-quic-simple-server-uni.js

Fixes: nodejs#35789
@mmomtchev mmomtchev linked a pull request that will close this issue Oct 25, 2020
Open
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

stream: fix async iterator not reading last chunk on close
1 participant
@mmomtchev
You can’t perform that action at this time.