Skip to content

/ EditorSyntax

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and enhance mulitple quoted string issues #173

Open
wants to merge 5 commits into
base: master
from
Open

Fix and enhance mulitple quoted string issues #173

wants to merge 5 commits into from

Conversation

@msftrncs
Copy link
Contributor

@msftrncs msftrncs commented May 9, 2019

  • Fixes #143, moving the double double-quote escape ("") in to doubleQuotedString from doubleQuotedStringEscapes, and removing the double single-quote escape ('') from the pattern for single quoted here-strings.

  • Fixes #167 (entirely), permitting white space to follow the opening token for here-strings, adding punctuation scopes to the start and end tokens (punctuation.definition.string…), and preparing some of the string regex's for the following change.

  • Closes #141, applying the PowerShell supported curly quotes \x{2018}-\x{201B} (single quotes) and \x{201C}-\x{201E} (double quotes), everywhere except for an occurrence in hashtable:

    EditorSyntax/PowerShellSyntax.tmLanguage

    Lines 1501 to 1504 in 44eac87

    <key>match</key>
    <string>\b((?:\'|\")?)(\w+)((?:\'|\")?)(?:\s+)?(=)(?:\s+)?</string>
    <key>name</key>
    <string>meta.hashtable.assignment.powershell</string>

    There are issues in this area, that nearly make the quotes in this section unusable.

  • Tests added for single quoted here-string, and the escaping issue of #143. There are currently no tests I found for punctuation.definition.string… for any kind of strings.
msftrncs added 5 commits May 9, 2019
@msftrncs
fixes #143
370d0c1 
moves double-quote double-quote escape from #doubleQuotedStringEscapes
to #doubleQuotedString.  Removes the single-quote single-quote escape
from single-quote here-string pattern.
@msftrncs
applies issue #167 part 1
0d4cbf8 
permits whitespace to follow here-string start token.
@msftrncs
tests for #143 and #167 part 1
bb41692
@msftrncs
fixes #141, adds support curly quotes
f9308e3 
indirectly applies #167 parts 2 and 3
@msftrncs
applies issue #167 part 4,
Loading status checks…
f5dfc7b 
adds punctuation scope to start/end of here-string
@msftrncs msftrncs mentioned this pull request May 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Quoted strings/here-strings issues
Double doublequotes in here-string scopes as a character.escape
Account for curly quotes in syntax definition.
1 participant
@msftrncs
You can’t perform that action at this time.