Skip to content

/ Go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming issues in the strings directory #149

Open
cclauss opened this issue Jun 18, 2020 · 2 comments
Open

Naming issues in the strings directory #149

cclauss opened this issue Jun 18, 2020 · 2 comments
Labels
automated testing

Comments

@cclauss
Copy link
Member

@cclauss cclauss commented Jun 18, 2020 •
edited

@halafi Can you please make some changes in https://github.com/TheAlgorithms/Go/tree/master/strings ?

  1. The directories contain spaces instead of dashes in the directory names. This forces us to quote the directory names when using command line tools such as linters.
  2. File names need work also. Is ac.go a calculation for alternating current or is it controller for an air conditioner? Is bom.go a tool for building a bill of materials or does it generate a byte order mark? Why does the reader have to guess?? aho-corasick.go is a much more self-documenting filename than ac.go.
  3. Can you help us to get the last two lines of .github/workflows/golangci-lint.yml to pass without || true?
@reverse reverse mentioned this issue Oct 2, 2020
Closed
@piyushs2894
Copy link

@piyushs2894 piyushs2894 commented Oct 11, 2020

@cclauss I have fixed the issues 1 and 2 and looking for 3rd as well. Can u please review and merge below PR for the same with "hacktoberfest-accepted" label.
#209
@piyushs2894
Copy link

@piyushs2894 piyushs2894 commented Oct 11, 2020

@cclauss Regarding golandci-lint failure, it is failing as in single_string_matching and multiple_string_matching directory, some methods like main, commandLineInput, and many more more are redeclared. Go does not allow same method name in single package. Is it has to be fixed ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automated testing
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@cclauss @piyushs2894
You can’t perform that action at this time.