Skip to content

/ SeleniumLibrary

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and cleanup logic related to frames #959

Open
pekkaklarck opened this issue Oct 18, 2017 · 5 comments
Open

Fix and cleanup logic related to frames #959

pekkaklarck opened this issue Oct 18, 2017 · 5 comments
Labels
backwards incompatible bug priority: high

Comments

@pekkaklarck
Copy link
Member

@pekkaklarck pekkaklarck commented Oct 18, 2017

There are currently several problems with handling frames that should be resolved. Some of these problems are already covered by existing issues, but this new issue list all these highly related problems in one place. The whole frame handling logic should be rewritten and all these problems resolved at the same time.

  1. Page Should (Not) Contain searches text from frames, but only searches from one level and not from sub frames (#98)
  2. Other keywords don't look inside frames at all. This includes Page Should (Not) Contain Element and Current Frame Should (Not) Contain. (#98)
  3. Page Should (Not) Contain internally selects the main frame, disabling earlier Select Frame calls.(#201)
  4. We should see could we deprecate all Current Frame ... keywords. It would be better that after selecting a frame, all subsequent keywords would operate in the frame. This may actually already be the case, except with Page Should (Not) Contain which looks from the root (see 3. above).
  5. If all keywords operate on the selected frame, Page Should is pretty misleading wording. Should we consider renaming these keywords like Page Should Contain -> Text Should Be Present, Page Should Contain Element -> Element Should Be Present?
This was referenced Oct 18, 2017
Closed
Closed
Closed
@pekkaklarck pekkaklarck added this to the v3.1.0 milestone Oct 18, 2017
@mcleanmds
Copy link

@mcleanmds mcleanmds commented Feb 2, 2018

Additionally to the problems already listed, there is a similar problem with the Frame Should Contain Keyword, the driver is switched back to the default context, which is undesirable when working on sub frames. (expected to end up at the window/frame that we started from, not the main window).
@aaltat aaltat modified the milestones: v3.2.0, v3.3.0 Mar 6, 2018
@aaltat aaltat modified the milestones: v3.2.0, v3.3.0 Sep 13, 2018
@aaltat aaltat removed this from the v3.3.0 milestone Dec 12, 2018
@tmaleckiplacester
Copy link

@tmaleckiplacester tmaleckiplacester commented Aug 30, 2019

Any update on this one?
@aaltat
Copy link
Contributor

@aaltat aaltat commented Aug 30, 2019

There is not progress for this issue because no-one has seen it enough important to invest time.
@MininAS
Copy link

@MininAS MininAS commented May 4, 2020

@pekkaklarck Do we have some progress in this issue :)
@aaltat
Copy link
Contributor

@aaltat aaltat commented May 4, 2020

Nothing has happened since my last comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backwards incompatible bug priority: high
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@pekkaklarck @aaltat @mcleanmds @tmaleckiplacester @MininAS
You can’t perform that action at this time.