Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd SameSite flag to work with Firefox Nightly #2545
+1
−1
Conversation
|
This is not working yet. It fixed in Firefox Nightly but breaks Chrome. The test result is: if we set "SameSite=None" only, it works in Chrome. But in Firefox Nightly it stops the user from logging in (keep showing the login page). On the other hand, if we set "SameSite=None;secure", Firefox Nightly likes it but Chrome (and Edge) keep showing the login page. I don't know what the correct solution should be; but I think ZeroNet will have to implement HTTPS and so "SameSite=None;secure" will work on both if using HTTPS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
A quick fix for #2544.
Tested in my own computer with doing the same to the
UiPasswordPlugin.pyfile.