Skip to content

/ oc

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.5] Bug 1884580: Set appropriate owner references when creating a job from cronjob #602

Merged
merged 1 commit into from Oct 22, 2020
Merged

[release-4.5] Bug 1884580: Set appropriate owner references when creating a job from cronjob #602

merged 1 commit into from Oct 22, 2020
+10 −5

Conversation

@soltysh
Copy link
Member

@soltysh soltysh commented Oct 2, 2020

/assign @ingvagabund
@soltysh
Bug 1884580: Set appropriate owner references when creating a job fro…
Verified
This commit was signed with a verified signature.
soltysh Maciej Szulik
GPG key ID: F15E55D276FA84C4 Learn about signing commits
Loading status checks…
9ed230c 
…m cronjob
@openshift-ci-robot
Copy link

@openshift-ci-robot openshift-ci-robot commented Oct 2, 2020

@soltysh: This pull request references Bugzilla bug 1884580, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1835066 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1835066 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

Bug 1884580: Set appropriate owner references when creating a job from cronjob

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@soltysh soltysh changed the title Bug 1884580: Set appropriate owner references when creating a job from cronjob [release-4.5] Bug 1884580: Set appropriate owner references when creating a job from cronjob Oct 2, 2020
@soltysh
Copy link
Member Author

@soltysh soltysh commented Oct 5, 2020

/retest
3 similar comments
@ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Oct 6, 2020

/retest
@soltysh
Copy link
Member Author

@soltysh soltysh commented Oct 7, 2020

/retest
@ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Oct 11, 2020

/retest
@ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Oct 11, 2020

/lgtm
@openshift-ci-robot
Copy link

@openshift-ci-robot openshift-ci-robot commented Oct 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Oct 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
2 similar comments
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Oct 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Oct 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.
@openshift-merge-robot openshift-merge-robot merged commit 6082e94 into openshift:release-4.5 Oct 22, 2020
10 checks passed
10 checks passed
ci/prow/build-rpms-from-tar Job succeeded.
Details
ci/prow/e2e-aws Job succeeded.
Details
ci/prow/e2e-aws-upgrade Job succeeded.
Details
ci/prow/e2e-cmd Job succeeded.
Details
ci/prow/images Job succeeded.
Details
ci/prow/rpm-build Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
ci/prow/verify Job succeeded.
Details
ci/prow/verify-deps Job succeeded.
Details
tide In merge pool.
Details
@openshift-ci-robot
Copy link

@openshift-ci-robot openshift-ci-robot commented Oct 22, 2020

@soltysh: All pull requests linked via external trackers have merged:

Bugzilla bug 1884580 has been moved to the MODIFIED state.

In response to this:

[release-4.5] Bug 1884580: Set appropriate owner references when creating a job from cronjob

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@soltysh soltysh deleted the soltysh:bug1884580 branch Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik

@smarterclayton smarterclayton

Assignees

@ingvagabund ingvagabund

Labels
approved bugzilla/severity-medium bugzilla/valid-bug cherry-pick-approved lgtm
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@soltysh @openshift-ci-robot @ingvagabund @openshift-bot @bparees @openshift-merge-robot
You can’t perform that action at this time.