Skip to content

/ ZeroNet

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding OGG MIME #2657

Merged
merged 2 commits into from Oct 26, 2020
Merged

Adding OGG MIME #2657

merged 2 commits into from Oct 26, 2020
+3 −0

Conversation

@JabbaDesilijicTiure
Copy link
Contributor

@JabbaDesilijicTiure JabbaDesilijicTiure commented Oct 20, 2020 •
edited

.ogg is not listed in the mimetypes module: https://github.com/python/cpython/blob/3.9/Lib/mimetypes.py and since we don't know whether the ogg file contains audio or video, we need an application/ogg mime for those files with the .ogg extension.
@JabbaDesilijicTiure
Adding OGG MIME
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
07a632a 
Fixing: #2656
@imachug
Copy link
Contributor

@imachug imachug commented Oct 21, 2020

This is not going to fix the mentioned issue but it's a worthy change anyway. Please add .ogv and .oga too though.
@JabbaDesilijicTiure
Copy link
Contributor Author

@JabbaDesilijicTiure JabbaDesilijicTiure commented Oct 21, 2020

@imachug since we don't know whether the ogg file contains audio or video, we need an application/ogg mime for those files with the .ogg extension.
@imachug
Copy link
Contributor

@imachug imachug commented Oct 21, 2020

Yes, that's why I asked you to add support for .ogv and .oga extensions as well, for which more specific MIME types can be defined.
@JabbaDesilijicTiure
Copy link
Contributor Author

@JabbaDesilijicTiure JabbaDesilijicTiure commented Oct 21, 2020

@imachug Makes no sense to add two mime types, when one is enough:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Configuring_servers_for_Ogg_media
@imachug
Copy link
Contributor

@imachug imachug commented Oct 21, 2020

Listen in. Even the article you're referring to notes that there are .ogg, .oga and .ogv extensions. All I'm asking for is that, if you added .ogg, please also add MIME types for .oga and .ogv.
@JabbaDesilijicTiure
Adding ova and ogv extensions
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
85a9d3d
@JabbaDesilijicTiure
Copy link
Contributor Author

@JabbaDesilijicTiure JabbaDesilijicTiure commented Oct 24, 2020

Adding ova and ogv extensions. 🙄
There you go @imachug added the oga and ogv extensions... You was right, need all 3 of them. Thanks
@JabbaDesilijicTiure JabbaDesilijicTiure mentioned this pull request Oct 24, 2020
Closed
@imachug
imachug approved these changes Oct 24, 2020
View changes
@HelloZeroNet HelloZeroNet merged commit 54fb2fd into HelloZeroNet:py3 Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imachug imachug

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@JabbaDesilijicTiure @imachug @HelloZeroNet
You can’t perform that action at this time.