Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile based on Ubuntu 20.04 #2652

Open
wants to merge 1 commit into
base: py3
from
Open

Conversation

@gukandrew
Copy link

@gukandrew gukandrew commented Oct 15, 2020

The official Dockerfile on alpine:3.11 doesn't work on Raspberypi OS (RPI4), this works fine

Copy link
Contributor

@JabbaDesilijicTiure JabbaDesilijicTiure left a comment

The file server port is always random!
The path should be ~/ and not root
Tor never should be run as root!
Also, ubuntu 16.04 EOL is a few months away April 30, 2021. You should test it on Ubuntu 20.04.1 LTS

@JabbaDesilijicTiure
Copy link
Contributor

@JabbaDesilijicTiure JabbaDesilijicTiure commented Oct 15, 2020

@imachug how you could approve this? 🙄

Dockerfile.ubuntu Outdated Show resolved Hide resolved
@JabbaDesilijicTiure
Copy link
Contributor

@JabbaDesilijicTiure JabbaDesilijicTiure commented Oct 15, 2020

@gukandrew You need to make significant changes. @imachug wrongfully approved your PR which is clearly dangerous.

@gukandrew
Copy link
Author

@gukandrew gukandrew commented Oct 15, 2020

I'm not sure about that changes, as I took the original Dockerfile as base. So that's why I have port and other things hardcoded as well as in original.
And you could use tor or not so you can set ENABLE_TOR env var.

Of course I can put your suggestions, but I think you can commit that directly (I have checked checkbox "Allow edits by maintainers").

@gukandrew
Copy link
Author

@gukandrew gukandrew commented Oct 15, 2020

@JabbaDesilijicTiure @imachug Btw why official docker image/dockerfile https://hub.docker.com/r/nofish/zeronet/dockerfile has same issues?

@imachug
Copy link
Contributor

@imachug imachug commented Oct 15, 2020

The file server port is always random!

That's difficult to implement in Docker, and the other dockerfile in this repo has a hardcoded port as well. Making it random counts as a feature request, but you shouldn't ask the OP to do that.

@imachug
Copy link
Contributor

@imachug imachug commented Oct 15, 2020

The only person who actually do something is @imachug.

Don't underestimate nofish who started this project and don't overestimate me who made a few contributions. We all burn out from time to time, it's okay.

@gukandrew
Copy link
Author

@gukandrew gukandrew commented Oct 16, 2020

@JabbaDesilijicTiure @imachug Wow I caught attention to more serious thing than I thought.
I'm not familiar with situation in Hungary, but if that is true it's terrible.
But in same time @HelloZeroNet is living in that country so maybe he is not talking about issues in Hungary because of concerns about close people life. IDK

@gukandrew gukandrew force-pushed the gukandrew:py3 branch 2 times, most recently from 14f2b65 to bcf447f Oct 16, 2020
@gukandrew
Copy link
Author

@gukandrew gukandrew commented Oct 16, 2020

I don't know a lot about China, but heard about Xinjiang re-education camps and The Great Firewall of China, that is also shows China not in good light (I do not justify the Hungary). Anyway the topic will not be fulfilled without mention that Russian Federation also is nazi country, that occupied Ukrainian Crimea and Eastern Donbas and asked support their actions for Hungary government at same time. So It would be hypocrisy to be silent about that from my side when topic goes about despotism. So what your thoughts about that fact?

@imachug @JabbaDesilijicTiure anyway I have fixed Dockerfile a bit, updated Ubuntu version and using virtualenv now.

Dockerfile.ubuntu Outdated Show resolved Hide resolved
Dockerfile.ubuntu Outdated Show resolved Hide resolved
@gukandrew
Copy link
Author

@gukandrew gukandrew commented Oct 17, 2020

Russia? Without Russia we already dead body, we will be all either dead or live in brutal fascism. I see Russia as a savior, they did save Europe from the nazis one time and I strongly believe soon they actually go to war with NATO fascists in EU and save Europe again from fascists.

Ha ha ha, they were nothing without Ukraine in WW2 as well as without USA's Lend-Lease.

Crimea was legally annexed and I support that move. I don't like double standards, the Americans annexed entire countries in Afghanistan, Iraq, and they "protecting oil" now in Syria, Americans also "annexed" Guantanamo Bay which is a true concentration camp. The real evil in this world is not China, Russia or Iran, the real evil and world's biggest terrorist which killing thousands of people with drones is the United States of America. I believe we are close to 3th world war and if that times come I volunteer to oust the Americans from Europe.

Did you heard about Budapest Memorandum and the freezing of borders after World War II? They don't have any legal rights to occupy any territory of Ukraine. I hope the war between China and Russia will happen soon, and you'll feel the things that we in Ukraine feel now protecting our territory against russians nazis. I see real face of supporting terrorism from your side like Russian Federation actions related their neighbors. So after that I can't believe your justification of china camps and russian occupants.
And yes, I don't care about other countries after Russia invaded Ukraine why I should though?

We will be on opposite sides.

@gukandrew
Copy link
Author

@gukandrew gukandrew commented Oct 17, 2020

Nope, I really disappointed with your position. You're doing the same thing you claim @HelloZeroNet does. But in your case that clearly visible things, unlike situation with Tamas Kocsis.

@gukandrew gukandrew force-pushed the gukandrew:py3 branch from bcf447f to e2c46b4 Oct 17, 2020
@gukandrew
Copy link
Author

@gukandrew gukandrew commented Oct 17, 2020

lol, turn off russia24 on your tv. Any proofs? Except russian occupation of my country?

@gukandrew
Copy link
Author

@gukandrew gukandrew commented Oct 17, 2020

Your country run by a clown didn't you noticed?

Why you care who run our country? Fuck off.

Neo-nazis waving EU flags and the whole government is working to get into the NATO

Why you care where other country goes? You have your China. So fuck off.

Russia should wipe out Ukraine from the map

Fuck off, you're really terrorist.
And no, I speak Ukrainian. As well as another part of country. But why you care what language another country use?

Actually crimeans voted to be part of Russia

It's fake claim, and fake referendum under the russian guns.

Fascist eurocentric russophobic maniacs should be gunned down and if this continues that way your country will be ground zeronet.

It's not you who can decide that, and not another countries even. So fuck off again.

@gukandrew
Copy link
Author

@gukandrew gukandrew commented Oct 17, 2020

Fuck off again. And put FSB into your ass before that. NaziJabbaDesilijicTiure.

@gukandrew
Copy link
Author

@gukandrew gukandrew commented Oct 17, 2020

I'm very scary. OMG.
@HelloZeroNet I cannot understand why this freak with nazi and terrorist views contribute this project.

@gukandrew
Copy link
Author

@gukandrew gukandrew commented Oct 17, 2020

image

@imachug
Copy link
Contributor

@imachug imachug commented Oct 17, 2020

@HelloZeroNet Please merge this PR and lock the discussion. And you guys please stop acting childish.

@imachug
Copy link
Contributor

@imachug imachug commented Oct 17, 2020

@gukandrew I am sorry for the insults. ZeroNet GitHub repository gets invaded by such people from time to time.

@gukandrew
Copy link
Author

@gukandrew gukandrew commented Oct 17, 2020

@imachug thank you! I was almost going to close that PR because of that. That's very destructive behavior really will not provide good feedback for the project.

@gukandrew
Copy link
Author

@gukandrew gukandrew commented Oct 17, 2020

@imachug sorry, one more thing. Question regarding virtualenv. Do we need that layer? As for me that would be overcomplicating, as we use our container only for ZN and could run as non root user even without virtualenv.

@gukandrew gukandrew changed the title Add Dockerfile based on Ubuntu 16.04 Add Dockerfile based on Ubuntu 20.04 Oct 17, 2020
@imachug
Copy link
Contributor

@imachug imachug commented Oct 17, 2020

As for me that would be overcomplicating, as we use our container only for ZN and could run as non root user even without virtualenv.

I think so too, perhaps we're not going to add more Python programs to the container.

The official Dockerfile on alpine:3.11 doesn't work on Raspberypi OS (RPI4), this works fine
@gukandrew gukandrew force-pushed the gukandrew:py3 branch from e2c46b4 to 4aace4d Oct 17, 2020
@gukandrew
Copy link
Author

@gukandrew gukandrew commented Oct 17, 2020

@imachug @HelloZeroNet dropped virtualenv. Now it should build faster.

@gukandrew gukandrew marked this pull request as draft Oct 17, 2020
@gukandrew gukandrew marked this pull request as ready for review Oct 17, 2020
@gukandrew
Copy link
Author

@gukandrew gukandrew commented Oct 20, 2020

Screenshot_2020-10-20 Add Dockerfile based on Ubuntu 20 04 by gukandrew · Pull Request #2652 · HelloZeroNet ZeroNet

@JabbaDesilijicTiure you cannot erase your position as easy as you think.

@scsmash3r
Copy link

@scsmash3r scsmash3r commented Oct 27, 2020

@gukandrew Not regarding the topic and discussion about the actual subject, but I think that this Jabba person is just an ordinary troll, whose aim is to insult other people and to enjoy his self-affirmation (I was insulted by him too). Just ignore him and report the tech stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.