Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Refactor commands #5
Closed
Conversation
|
@lex111 Excellent! I'll certainly review your PR next week! Many thanks! :) |
|
Many thanks @lex111 ! I'll be merging your PR to branch 2.0.10-dev. Your changes will therefore be included in the next release of Linux for Composer! |
|
Merged on 2.0.10-dev, commit f9e8e2c. |
|
@andrewscaya great, but I will continue refactoring in next PRs, as I wrote earlier, these are not final changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi @andrewscaya, I hope you are well,
History: about a year ago, I expressed a desire to work on improving your project... And finally, I start doing refactoring, although maybe it doesn't make much sense, because it's just refactoring😃
Anyway, this is only the first part of refactoring that I have planned. I want to split the codebase so that I end up making the commands easier to maintain and understand.
In this PR:
BaseCommandto reduce code duplication (methods for Windows).Diff changes aren't big, so it shouldn't be hard to examine. Please take some time for them, I want to continue what I started.