Horgix
Follow
Pinned
1,467 contributions in the last year
Less
More
Activity overview
Contributed to
Vermeille/Torchelie,
xebia-france/certifications,
xebia-france/scaleway-breakathon
and 5 other
repositories
Contribution activity
May 2021
Created 82 commits in 1 repository
Created a pull request in Vermeille/Torchelie that received 5 comments
Opened 33 other pull requests in 1 repository
Vermeille/Torchelie
31
merged
1
open
1
closed
- 📝 docs(readme): add some pretty badges
- 👷 chore(ci): lint for static types using mypy (Closes #28)
- 👷 chore(ci): add code lint workflow (Closes #53)
- 👷 chore(ci): disable run on PRs since we already run on every push
- 🎨 lint(examples): fix all minor style warnings
- 🎨 lint(tests): fix minor style warnings
- 🎨 lint(everything): last small style fixes on torchelie/ code
- 🔧 chore(flake8): add flake8 configuration file with some ignores
- 🚨 lint(nn/conv): use normal string instead of format-string (F541)
- 🚨 lint(stylegan2): use normal string instead of format-string (F541)
-
🐛 fix(nn/utils):
netdoesn't have to be on CPU anymore (now uses device) -
🎨 lint(neuralstyleloss): fix PEP8 warning about
not inmembership test (E713) -
🗑 lint(lr_scheduler): remove duplicate import of
Tuple(F811) - 📝 docs(readme): add note about using 'l' as variable name in the context of Torchelie
-
♻️ lint(everything): rename all occurences of
lvariables into more meaningful names (E741) - 🔥 refactor(loss/bitempered): remove __main__ function left from previous testing
- 🎨 lint(utils, opti, nn/layers): put module level imports at top of file (E402)
- 🎨 lint(everything): fix indentation levels (E121, E125, E126, E127, E128, E131)
- 🎨 lint(resnet, stylegan2): fix PEP8 warnings on many # for block comments (E266)
- 🎨 lint(everything): fix PEP8 warnings about whitespaces around parameter equals (E252)
- 🎨 lint(nn, datasets): fix PEP8 warnings about whitespace around operator (E225)
- 🎨 lint(everything): fix PEP8 warnings about line break after bin operator (W504)
- 📝 docs(readme): bootstrap contribution guidelines
- 🐛 fix(tests/nn): use new name Conv2dBNReLU → ConvBlock
- 🔥 deprecation(recipes): remove upsampling and upsamplinggan
- Some pull requests not shown.
Created an issue in Vermeille/Torchelie that received 4 comments
Images for run_tests.sh are missing
I wanted to run the run_tests.sh script at the root of the repo but the images it uses seem to be missing:
tests/dream_me.jpg
tests/style.jpg
Whi…
4
comments
Opened 19 other issues in 2 repositories
Vermeille/Torchelie
15
open
3
closed
- Move Contributing guidelines to a dedicated file and mention it in README
-
Remove the
v1.1branch? - Which Python versions are supported?
- Add some CI badges
- Enable tests reports on CI so GitHub Actions checks have more insights
- Run tests that depend on OpenCV in the CI
- Run lint from CI
- Add some kind of "dev dependencies" with pytest, flake8, yapf, etc.
- Use BugBear's 10% line length rule for flake8 to extend 80 columns limitation in lint (would get rid of some E501)
- Fix chained imports mess / hell (will get rid of both F403 and F405)
-
Tighten up bare
excepts around the codebase (would also fix E722 warnings) -
Use
__all__to declare modules public APIs (would also fix F401 warnings) -
Refactor
CallbacksRunnerto use proper members instead of hacky lists -
Run the whole
run_tests.shin CI -
Raise real Exceptions instead of using
assert False -
Document
mypyusage in README "Contributing" section -
Run
mypytype checking in CI workflow -
Replace
MConvBNReLUby constructingPixelCNNwith simpleConvBlocks + model edition
github/super-linter
1
open
1
contribution
in private repositories
May 5