Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about headerReader.decode() #25

Open
iyangsj opened this issue Nov 11, 2015 · 0 comments
Open

Question about headerReader.decode() #25

iyangsj opened this issue Nov 11, 2015 · 0 comments

Comments

@iyangsj
Copy link

@iyangsj iyangsj commented Nov 11, 2015

  1. headerReader.decode() is not concurrency-safe, but is called by stream.serve() which is running in different goroutines. (serve() -> stream_loop() -> initiate_stream())
  2. As I understand it, there is a single zlib stream for all name value pairs in one direction on a connection. headerReader.decompressor should be created using data in first SYN_STREAM stream, but there is no guarantee for this. (The goroutine for first SYN_STREAM may run after goroutine for other SYN_STREAM)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.