Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SkSurface::MakeFromMTLTexture #67

Closed
wants to merge 1 commit into from

Conversation

@knopp
Copy link

@knopp knopp commented Oct 6, 2020

Something like this would be required to get partial redraw in flutter working for metal. Related issues:

flutter/flutter#67056
flutter/flutter#33939

@knopp knopp force-pushed the knopp:surface_from_metal_texture branch from f02d6ad to 06e9194 Oct 6, 2020
@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Oct 6, 2020

@knopp : Skia didn't use Github for contribution. Please check https://skia.org/dev/contrib on how to file issues or contribute code to Skia.

@knopp
Copy link
Author

@knopp knopp commented Oct 6, 2020

@liyuqian, I put this here for now, more or less as placeholder, because I can't seem to be able to create any issue in skia issue tracker. EDIT: But thanks for the heads-up, I'll try to submit the patch directly.

@jvanverth
Copy link
Contributor

@jvanverth jvanverth commented Oct 7, 2020

Please don't submit this. You can use SkSurface::MakeFromBackendRenderTarget or SkSurface::MakeFromBackendTexture to do the same thing.

@knopp
Copy link
Author

@knopp knopp commented Oct 7, 2020

Thanks. I'll look into it.

@knopp knopp closed this Oct 7, 2020
@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Oct 7, 2020

@knopp : Skia said that the public should be able to create issues on https://skbug.com. Can you please check if you've logged in with a Google/gmail account?

@knopp
Copy link
Author

@knopp knopp commented Oct 7, 2020

@liyuqian, I wasn't able to submit feature request last week, but I tried submitting a bug report now and it worked. I'm not sure if feature requests are treated differently or the issue got resolved in the meanwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.