Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User name and password prompts are missing from the GitHub Sign-In dialog in Visual Studio 2019 #2556

Open
CLIRResearch opened this issue Oct 3, 2020 · 9 comments

Comments

@CLIRResearch
Copy link

@CLIRResearch CLIRResearch commented Oct 3, 2020

Versions

  • GitHub Extension for Visual Studio version: ...
  • Visual Studio version: ...

What happened

I have a new solution that I would like to publish to a remote private repository on GitHub. When I try to connect to GitHub, I get a dialog that offers the following options:

GitHub
GitHub Enterprise
Sign in with your browser
Sign up

There are no prompts for User name and password. There is now way to sign in to my existing GitHub repositories from the Connect to GitHub.

How do I point a solution to a GitHub repository? How do I publish my local repository to my private repository on GitHub? Is there any way to know what my origin repository is from Team Manager? Has support for GitHub been dropped? What is the point of the "Sign in with your browser" link? Do I have to manage repositories outside of VS2019 now?

Steps to Reproduce

Steps to reproduce the behavior:

  1. Create a new solution and local repository.

  2. Go to Team Manager,

  3. Click Manage Connections | Connect to GitHub.

  4. The GitHub Sign In page appears. There is no prompt for User name or password.

Is it at all possible to set the GitHub account information else where?

  1. Click on '....'
  2. Scroll down to '....'
  3. See error

Expected behavior

Screenshots

Logs

Additional context

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Oct 5, 2020

Hi @CLIRResearch,

There are no prompts for User name and password. There is now way to sign in to my existing GitHub repositories from the Connect to GitHub.

Did you try clicking on the Sign in with your browser?

The option to connect using a username and password is going away. See here for more details:
https://developer.github.com/changes/2020-02-14-deprecating-password-auth/

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Oct 21, 2020

Hi @CLIRResearch,

Did you ever manage to sign in using your browser?

image

@CLIRResearch
Copy link
Author

@CLIRResearch CLIRResearch commented Oct 21, 2020

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Oct 21, 2020

Before last Saturday afternoon, getting to my repository from the browser was never an issue. After Saturday afternoon, the sign-in from the GitHub pane in VS2019 produced a 404 error. If I took the URL that was reporting the 404 error, opened another browser and, pasted the URL into the address bar; I went to my repo without any issue.

The sign-in process should take you to github.com to authenticate and then redirect to a localhost address. Did the 404 error happen as soon as you clicked Sign-in with you browser or after you authenticated?

We had asked if the GitHub extension for VS2019 had been deprecated. Until yesterday we were told that it had not. I wondered because the documentation for the extension had not been updated after the user name and password had been removed from the sign in dialog.

Accessing the GitHub API using a username and password is being deprecated for security reasons. The issue is the same username and password could be used to take over someone's account on github.com. By only allowing browser sign-in, we can do 2FA and other enhanced security checks.

@CLIRResearch
Copy link
Author

@CLIRResearch CLIRResearch commented Oct 21, 2020

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Oct 21, 2020

After completing a new C# class in the afternoon, I went to Team Explorer and went to Changes. There were no changes shown. When I went to “View History” there was no history.

When you went to View History, was the History tab completely blank?

This is what it should look like:
image

What happens if you click on the up-arrow or Add to Source Control button on the status bar? Do you see an option to Publish to GitHub?

image

Note, the Team Explorer functionality is actually part of Visual Studio and not the GitHub for Visual Studio extension.

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Oct 21, 2020

I would recommend that the empty space on the Sign-In dialog (where user name and password were) be used to explain when you need to authenticate.

This is a good suggestion, thanks!

@CLIRResearch
Copy link
Author

@CLIRResearch CLIRResearch commented Oct 21, 2020

@joojoodamn
Copy link

@joojoodamn joojoodamn commented Oct 22, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.