Skip to content
This repository has been archived by the owner. It is now read-only.

Fix for #500 #535

Open
wants to merge 1 commit into
base: master
from
Open

Fix for #500 #535

wants to merge 1 commit into from

Conversation

@lswith
Copy link

@lswith lswith commented Aug 31, 2017

This fixes the issue #500

Luke Swithenbank
@facebook-github-bot
Copy link

@facebook-github-bot facebook-github-bot commented Aug 31, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

iandundas added a commit to iandundas/SocketRocket that referenced this pull request Oct 13, 2017
@jimocallaghan
Copy link

@jimocallaghan jimocallaghan commented Jan 24, 2018

Is there a chance this PR will get merged? We're facing the same issue - need some of the other post r0.4.2 fixes also and without this are getting bounced on iTunes upload with ITMS-90056 - "The Info.plist file is missing the required key: CFBundleVersion."

@dzenbot
Copy link

@dzenbot dzenbot commented Feb 20, 2018

This issue is now blocking the submission to the AppStore.
image

Please merge this change soon.

@iandundas
Copy link

@iandundas iandundas commented Feb 22, 2018

Please can this be merged soon.

@dzenbot
Copy link

@dzenbot dzenbot commented Feb 22, 2018

@dzenbot
Copy link

@dzenbot dzenbot commented Feb 27, 2018

The build error on Travis is unrelated to this change FWIW. Someone with access needs to trigger a rebuild.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.