Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crontab timer function to run periodic job #65

Open
wants to merge 4 commits into
base: master
from

Conversation

@lqhuang
Copy link

@lqhuang lqhuang commented Oct 23, 2020

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

Hey, Ask. Thanks for your project.

I'm using mode as base framework to build some applications, but I found missing some features about Service.timer and Service.task.

So I try to add a crontab based timer into mode, and the major implementation is ported from faust code base.

It won't be better you could help to review this PR. If there are some problems, I can follow your instruction to improve them.

Would you like to merge this function into master branch and release a new version?

Regards.


NOTE: All patches should be made against master, not a maintenance branch like
3.1, 2.5, etc. That is unless the bug is already fixed in master, but not in
that version series.

If it fixes a bug or resolves a feature request,
be sure to link to that issue via (Fixes #4412) for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.