irfansharif
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
1,115 contributions in the last year
Activity overview
Contributed to
cockroachdb/cockroach,
cockroachdb/cockroach-gen,
cockroachlabs/release-staging
and 5 other
repositories
Contribution activity
September 2020
Created a pull request in cockroachdb/cockroach that received 15 comments
server: always create a liveness record before starting up
Previously it used to be the case that it was possible for a node to be up and running, and for there to be no corresponding liveness record for it…
+197
−51
•
15
comments
- kvserver: add assertions for invariants around liveness records
- kvserver: improve a comment around node liveness
- [wip,dnr,dnm] server,cli: bar decommissioned nodes from re-joining the cluster
- [wip,dnm,dnr] kvserver,kvcoord: batch txn heartbeats
- localtestcluster: re-order setting of gossip descriptor
- kvserver: address migration concern with node liveness
- release-20.2: server: always create a liveness record before starting up
- server: introduce Test{ClusterConnectivity,JoinVersionGate}
- server: improve error handling in join rpc
- opt: switch up const iota definitions to not confuse tooling
- testutils: improve TestCluster{Interface,Factory} API
- server: always create a liveness record before starting up
- server: defer gossip start to when absolutely needed
- rfc: Non-Blocking Transactions
- roachtest: disable load-based splitting in copy/bank/rows=10000000,nodes=9,txn=false
- release-20.2: deps: bump cockroachdb/redact
- roachtest: enable jemalloc profiling in all roachtests
- server: introduce Test{ClusterConnectivity,JoinVersionGate}
- server: always create a liveness record before starting up
- cli: allow SQL commands to use password authn in more cases
- pgwire: accept non-TLS client conns safely in secure mode
- server: improve error handling in join rpc
- server: defer gossip start to when absolutely needed
- testutils: improve TestCluster{Interface,Factory} API
- deps: bump cockroachdb/errors and cockroachdb/redact
Created an issue in cockroachdb/cockroach that received 2 comments
ui: improper grouping of nodes by node addresses
Reported privately in cockroachlabs/support#584. Hm, they're running into a real admin UI bug I think. Like mentioned above, n14 was originally ru…
2
comments
2
contributions
in private repositories
Sep 2